search

posit-dev / positron

Positron, a next-generation data science IDE
Other
1.98k stars 60 forks source link

Runtime/notebook integration may be causing stability problems in Jupyter notebooks #3805

Open ntluong95 opened 3 weeks ago

ntluong95 commented 3 weeks ago

Positron Version:

Positron Version: 2024.06.1 (system setup) build 2024.06.1-27 Code - OSS Version: 1.90.0 Commit: a893e5b282612ccb2200102957ac38d3c14e5196 Date: 2024-06-26T01:33:58.809Z Electron: 29.4.0 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0.22621

Steps to reproduce the issue:

  1. Open a Jupyter Notebook
  2. Run a random cell

To be honest, I don't know how to reproduce the problem. It works fine for me before but not now

What did you expect to happen?

The cell run

Were there any error messages in the output or Developer Tools console?

The cell didn't run. As can be seen from the screenshot, it took 11 minutes and not yet finished package loading image

juliasilge commented 3 weeks ago

If this happens in a reproducible way for you (or even if something seems to make it happen more often), please do share that with us!

seeM commented 2 weeks ago

One possible issue I can see from the code is that we aren't listening to and handling session.onDidEndSession in the NotebookSessionService for potential errors after startup.

petetronic commented 2 weeks ago

Something like this may also be behind https://github.com/posit-dev/positron/issues/3919?

seeM commented 2 weeks ago

@petetronic yes that sounds very possible.