posit-dev / positron

Positron, a next-generation data science IDE
Other
1.8k stars 50 forks source link

Authentication problem with GitHub Pull Requests extension #3873

Closed strengejacke closed 1 week ago

strengejacke commented 1 week ago

I get this warning message from the GH PR extension, which I don't get in VSCode. My question is whether we need some additional settings in our GitHub repos (I couldn't find anything related yet), or if this is a Positron bug?

image

juliasilge commented 1 week ago

I expect this is related to #3355.

@jmcphers can you take a look when you get a chance and see if we can change the OAuth app so it plays nicer with organizations like this one?

jmcphers commented 1 week ago

Yes, I think this is related to #3355. That change gave Positron its own third-party app identity. If the organization only allows access by approved third-party apps, then the organization needs to add Positron to the approved list.

@strengejacke This would be an organization level (rather than repo level) change. You can find instructions here: https://docs.github.com/en/organizations/managing-oauth-access-to-your-organizations-data/approving-oauth-apps-for-your-organization

strengejacke commented 1 week ago

But how can we add Positron to that list?

jmcphers commented 1 week ago

Are you able to create an approval request? https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/requesting-organization-approval-for-oauth-apps

strengejacke commented 1 week ago

It's a bit hidden, not quite exactly what the docs say, but I found it and it works, thanks!

jmcphers commented 1 week ago

Great, glad to hear it!