search

posit-dev / positron

Positron, a next-generation data science IDE
Other
2.39k stars 70 forks source link

Custom size dialog window in the plot pane should accept new values after hitting "enter" #4203

Open strengejacke opened 1 month ago

strengejacke commented 1 month ago

System details:

Positron and OS details:

Positron Version: 2024.07.0 (system setup) build 2024.07.0-125 Code - OSS Version: 1.91.0 Commit: cae4905332a0f41a6233e196b48a6679b832000a Date: 2024-07-31T22:26:02.970Z Electron: 29.4.0 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0.22631

Interpreter details:

R 4.4.1

Describe the issue:

When I change the custom size for plots in the plot pane, I need to click with the mouse on the OK button to accept. Would be nice if the "enter" key would also trigger the OK button.

sharon-wang commented 1 month ago

This is closely related to https://github.com/posit-dev/positron/issues/3491 and any other custom modals in Positron that have a default button (such as OK).

strengejacke commented 1 month ago

You mean #3491? @ posit-team, feel free to close this in favor of #3491

sharon-wang commented 1 month ago

Oops, yes that's what I meant :)

@juliasilge shall we keep just one of #3491 or #4203 open and transfer the labels and milestone as appropriate?

juliasilge commented 1 month ago

Let's keep them both open so we can validate the fixes for both cases. I will update so both are in 2024.09.0 Pre-Release.