posit-dev / positron

Positron, a next-generation data science IDE
https://positron.posit.co
Other
2.82k stars 91 forks source link

Remove fields from manifest that cause PWA install behavior. #5319

Closed nstrayer closed 1 week ago

nstrayer commented 1 week ago

This PR removes the fields in web mode that prompt the user to install positron to their desktop. This behavior was caused by positron being setup as a "progressive web app."

Before

Screenshot 2024-11-08 at 3 42 36 PM

After

Screenshot 2024-11-08 at 3 43 31 PM

Potential downsides

I don't think this manifest adjustment will cause any issues with other PWA niceties but it's a possibility. I didn't notice anything out-of-the-ordinary in my brief testing.

QA Notes

I tested locally running the "Positron Server (Web)" debug mode. Should be good for deployed-as-server scenarios as well.

nstrayer commented 1 week ago

Not needed as upstream PR will address.