New function to expose more info about an installed package - Githubissues

posit-dev / positron

Positron, a next-generation data science IDE

https://positron.posit.co

Other

2.82k stars 90 forks source link

New function to expose more info about an installed package #5365

Closed jennybc closed 3 days ago

jennybc commented 1 week ago

Addresses #1957

Requires https://github.com/posit-dev/ark/pull/625

What's the payoff?

Sometimes you want to get info about a package version without necessarily challenging the user to install/upgrade. (I need this to finish #5231, for example).
If you do need to invite the user to install or upgrade a package, this extra info allows us to build a better message.

QA Notes

To experience that checkInstalled() still works and to see the user-facing message in the absence of a minimum version requirement, here's one idea:

Remove the styler package: remove.packages("styler")
Trigger the Format Document command

You should see this:

Screenshot 2024-11-13 at 3 46 39 PM

To experience that checkInstalled() still works and to see the user-facing message in the presence of a minimum version requirement, here's one idea:

Install renv at a version below positron-r's minimum version, which is currently 1.0.9. I would do this with pak::pak("renv@1.0.8").
Walk through File > New Project > R Project and click the box to use renv:

As the new project is being stood up, you should see this:

Screenshot 2024-11-13 at 3 37 12 PM

jennybc commented 1 week ago

I'm going to bring caching back with a bit of modification. Stay tuned.

jennybc commented 6 days ago

OK @juliasilge this is done now, complete with restored and upgraded caching. Additional work that is not shown here: I temporarily added lots of logging to verify that the cache was being used/updated as expected and I was satisfied with the results.

jennybc commented 6 days ago

I have already rebased and force pushed this PR branch to include the ark version bump I did earlier today. Do you need to refetch this branch? Any chance you've got a local ark build that's getting used in the dev build instead of the 0.1.154 release from this afternoon?

jennybc commented 6 days ago

I just re-did the QA step described above and I'm still getting the desired pop-up, with locally built ark and after doing cargo clean forcing an ark release download:

Screenshot 2024-11-15 at 5 39 58 PM

juliasilge commented 6 days ago

I think it's possible what we need is step 4 here, like this commit.

jennybc commented 6 days ago

🤔 step 4 has happened, in main, in 34695a1276d865021bc4ffaac5a0746615956341. And this PR is rebased on that.

Here's the ark requirement in positron/extensions/positron-r/package.json in this branch:

https://github.com/posit-dev/positron/blob/d0e363d222ac0d6936be3925281902a5be82a2ee/extensions/positron-r/package.json#L673

It does feel like an ark mismatch. Does .ps.ark.version() report 0.1.154 in your dev build?

jennybc commented 6 days ago

I made one more change, but it would not explain what you're seeing (a complete lack of prompt).