posit-dev / positron

Positron, a next-generation data science IDE
https://positron.posit.co
Other
2.82k stars 90 forks source link

Fix R restart test with new Kallichore build #5387

Closed jmcphers closed 6 days ago

jmcphers commented 6 days ago

Addresses https://github.com/posit-dev/positron/issues/5356; fixes restarts on R and re-enables the R console tests.

The bug was upstream, in the supervisor; the issue was that during a restart, the channel that broadcast status updates to the client would blink offline. If the 'starting' status got sent during that blink, the client would miss it and not detect startup correctly. The fix is to ensure the channel always broadcasts updates throughout the restart cycle.

QA Notes

As noted by @jonvanausdeln, this is 100% reproducible on Windows, so it should be easy to test the fix there.

jonvanausdeln commented 6 days ago

Works on my windows box!