posit-dev / positron

Positron, a next-generation data science IDE
https://positron.posit.co
Other
2.82k stars 90 forks source link

tibble::view no longer works as intended in Positron (outputs error: variable name limitation) #5392

Closed anbrav0 closed 3 days ago

anbrav0 commented 5 days ago

related to: #4702 and the closed PR in https://github.com/tidyverse/tibble/pull/1603

Not sure if this is a regression, as the PR was closed and so was issue #4702

System details:

Positron and OS details:

Positron Version: 2024.11.0 (Universal) build 140
Code - OSS Version: 1.93.0
Commit: e0d844b031f95acbf89f234a2cce2af9b6721f6c
Date: 2024-10-31T14:24:19.540Z
Electron: 30.4.0
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.1.0

Interpreter details:

R 4.4.1

Describe the issue:

calling palmerpenguins::penguins |> tibble::view() outputs the following error:

Image

Steps to reproduce the issue:

  1. run palmerpenguins::penguins |> tibble::view() and palmerpenguins::penguins |> utils::View() in the Positron console
  2. Observe the different behaviors

Expected or desired behavior:

calling palmerpenguins::penguins |> tibble::view() should output similar behavior to palmerpenguins::penguins |> utils::View()

Were there any error messages in the UI, Output panel, or Developer Tools console?

palmerpenguins::penguins  |> tibble::view()
Error in `exists()`:
! variable names are limited to 10000 bytes
Hide Traceback
    ▆
 1. ├─tibble::view(palmerpenguins::penguins)
 2. │ └─rlang::eval_tidy(quo(view_fun(!!x, !!title)))
 3. └─view_fun(`<tibble[,8]>`, "palmerpenguins::penguins")
 4.   ├─base::isTRUE(exists(object_name, envir = parent.frame(), inherits = FALSE))
 5.   └─base::exists(object_name, envir = parent.frame(), inherits = FALSE)
isabelizimm commented 3 days ago

Thank you for the report!! ⭐ I'm able to confirm this broken behavior on Positron Version: 2024.11.0 (Universal) build 140 with tibble version 3.2.1.

DavisVaughan commented 3 days ago

I'm fairly certain this is fixed by https://github.com/tidyverse/tibble/pull/1603, it just hasn't gotten on CRAN yet. So pak::pak("tidyverse/tibble") plus a restart of R would fix it

juliasilge commented 3 days ago

This does in fact work correctly with the development version of tibble:

Image

@anbrav0 please let us know if you continue to have problems with the dev version of tibble!

anbrav0 commented 3 days ago

Thank you all!