posit-dev / positron

Positron, a next-generation data science IDE
https://positron.posit.co
Other
2.82k stars 90 forks source link

python ci: update macos version to latest #5406

Closed isabelizimm closed 3 days ago

isabelizimm commented 3 days ago

from errors noted in #5405 ; macos-12 has been deprecated https://github.com/actions/runner-images/issues/10721

seeM commented 3 days ago

Ah, seems CI is failing, worth checking upstream to see how they've handled this.

isabelizimm commented 3 days ago

Ah, this is coming back to me; upstream does not run macos tests 😬 going to try 13 to see if that works to get us unblocked, but can dig in a little deeper on the failure otherwise

https://github.com/microsoft/vscode-python/blob/5f0279abdf04a640210d6b3f4456fbe364741c08/.github/workflows/pr-check.yml#L146

isabelizimm commented 3 days ago

Okay, looks like miniconda used to be shipped in macos on GHA, but as of macos-13 that is no longer the case. https://github.com/actions/runner-images/discussions/9748 We'll have to install it on our own in CI