search

posit-dev / positron

Positron, a next-generation data science IDE
Other
2.49k stars 77 forks source link

Restore support for serving at non-root paths #961

Open jmcphers opened 1 year ago

jmcphers commented 1 year ago

About a year ago, we pulled in a patch from code-server which allows the web version of Positron to be served at non-root paths.

https://github.com/rstudio/positron/commit/8051d6185561f4d9fbcea8d0eb13f3f8e30ca792

Serving at a non-root path is a perquisite to working in Posit Workbench, since its sessions are proxied behind Workbench URLs.

In the year since this patch was merged, however, VS Code has had a lot of churn in the affected files, and fragments of the patch have been lost or become damaged by bit-rot. It is unlikely that it still works, and we have not tested it.

We should bring this patch back up to date, such that it is possible to serve the web version of Positron behind a path-rewriting proxy like Posit Workbench.

jmcphers commented 1 month ago

This may be addressed by https://github.com/posit-dev/positron/issues/4273 since I believe Workbench already serves VS Code behind a path-rewriting proxy.