posit-dev / product-doc-theme

Shared theme for Posit product documentation
https://docs.posit.co/
MIT License
5 stars 1 forks source link

code font weight #29

Closed aronatkins closed 5 months ago

aronatkins commented 5 months ago

The font / colors used by the theme provide less of a distinction between comments and code. Not sure that we want to make change, but creating this issue to document the change.

With the theme:

image

With cosmo:

image
AshleyHenry15 commented 5 months ago

I'll look at this one since I'm currently working with the style sheets and messing with the blocks for dark theme.

I haven't touched this property in the style sheet, so it appears that it may also be a default for Quarto. Unless, we have a need for the change, I would lean towards sticking to the quarto default and put a request in with them for the change/to see what is controlling this

AshleyHenry15 commented 5 months ago

Connect code color: color: #20794D;

Posit theme ("default") code color color: #20794D;

The comment color is also the same.

The difference may be due to the font styles used - Posit calls for $font-family-monospace: "Source Code Pro", monospace;

The only difference seems to be the font weight/type which is heavier with the theme.

I think that this is going to be a close - don't fix.