search

posit-dev / product-doc-theme

Shared theme for Posit product documentation
https://docs.posit.co/
MIT License
5 stars 1 forks source link

callouts are more muted #32

Closed aronatkins closed 5 months ago

aronatkins commented 5 months ago

This difference may be intentional; filing to track that change.

This theme uses a more muted shared of red for important callouts. For example:

image

This same callout with cosmo:

image
aronatkins commented 5 months ago

The difference is less obvious for Note.

Theme:

image

cosmo:

image
aronatkins commented 5 months ago

Warning has chosen to use a more yellow color.

Theme:

image

Cosmo:

image
aronatkins commented 5 months ago

Tip is a darker shade.

Theme:

image

Cosmo:

image
AshleyHenry15 commented 5 months ago

This is the default (without the cosmo theme). They appear very similar to what quarto.org has which leads me to believe that this is the default for quarto.

AshleyHenry15 commented 5 months ago

We can keep this open for tracking but unless it doesn't meet accessibility standards, I think that this is something that we leave.

aronatkins commented 5 months ago

I'm fine closing. It's not a Quarto default, but the "default" theme.

default: https://bootswatch.com/default/ cosmo: https://bootswatch.com/cosmo/

aronatkins commented 5 months ago

Quarto describes its themes and the Bootstrap default: https://quarto.org/docs/output-formats/html-themes.html

aronatkins commented 5 months ago

Making trouble. 😈 We could:

  formats:
    html:
      theme: [cosmo, theme.scss]
AshleyHenry15 commented 5 months ago

Making trouble. 😈 We could:

  formats:
    html:
      theme: [cosmo, theme.scss]

@aronatkins - isn't this what we were trying to avoid in the first place? 😭

aronatkins commented 5 months ago

isn't this what we were trying to avoid in the first place?

No, not really. This suggestion is modifying what theme is used as the starting point for our theme.

Today, we have:

    html:
      theme: [theme.scss]

If I understand how Quarto merges themes correctly, this is effectively the same as:

    html:
      theme: [default, theme.scss]

I might be wrong about default, though, and the starting point might be none.

I was suggesting that we could choose any of the Bootstrap themes, like cerulean or cosmo, as the basis for the theme rather than building on the default. If one of the themes is close to what we want, it could decrease some of the styling we need to do ourselves.

That said, default is fine, and it explains the callout styling differences for Connect.