Closed AshleyHenry15 closed 4 months ago
Visual feedback for dark-mode. I was testing using Safari. None of this is must-fix; only recording my initial reactions. Also keep in mind that I am not the target audience for this theme.
The font/color choices for code blocks and inline code make them feel more prominent than the surrounding text. Here's one small example, but it also applies to other occurrences.
This felt especially pronounced with the "Output or filenames" code chunk; it drew my eye over everything else on the page.
Table headers feel more visually prominent in dark mode than in light mode. This may be because they use a brighter color than the surrounding text. The fact that they are bold makes them more of a visual draw than the accompanying section header.
Table row highlighting feels much more subtle in dark mode than in light mode.
The nested tabset beneath the "code" pill is doing some strange things.
First, there appears to be a tiny underline lingering on the left, perhaps because the bubble around RHEL is too large?
Second, on mouseover, the whole set of headings shifts around. This screen recording shows the effect:
The callout icons probably need to be a lighter color.
@aronatkins - The nesting of the pills and tabs gets weird. I am assuming that it is due to the nesting of the different styles. I think that I will remove the example from the file for now until I can dive in and figure out if there is a way to make that work nicely.
th
class, and it should be fixed now.
This PR adds a dark theme and resolves other theme-related issues:
Resolves #57 Resolves #7
Known issues:
56
59
Flashing: https://github.com/quarto-dev/quarto-cli/issues/1325
Outstanding items tracking:
Before we merge:
Link to view docs: https://ashley.quarto.pub/theme-testing/