search

posit-dev / publisher

MIT License
3 stars 0 forks source link

Code signing for MacOS binary #1218

Open mmarchetti opened 3 months ago

mmarchetti commented 3 months ago

If this affects the version bundled with the VSCode extension, we'll need to do this sooner. otherwise, it can be closer to launch.

jonkeane commented 3 months ago

Ok, confirmed that this does not impact the vscode extension (regardless of download method). It does however impact downloading a file with a browser and then attempting to use the CLI from there.

The install.bash script works just fine (curl is apparently enough to avoid this warning). Folks also can open in finder (with right click) and mark ok.

All of this is to say: I'm moving this to beta, the CLI is (rightfully) not strongly supported right now, and there are ways around it. But if we do offer the CLI as a separate download when we get to beta, it would be good to do the sign+notarize dance for macOS