Closed sagerb closed 15 hours ago
Fantastic. Tested all the different options, and the steps always looked right.
The only weirdness is if you select "Create a New Credential" then click back the steps still show
3/6
I think this is still valid though.
It is difficult to think what is correct here... With the current option being create new, it is valid that it will take 6 steps, but if you change it to using an existing, we don't modify the steps dynamically in order to show that it now will only be 2 or 3 (whichever it is). It would probably be a GOOD change, although I'm unsure how expensive it would be to extend the framework to support it. Let's wait until we get some feedback that it is confusing...
Intent
This moves the entry point selection and the title entry up to the beginning of the New Deployment
multiStepInput
.Resolves #1784
Type of Change
Approach
The diff is strange because of the similar code blocks. I updated the
steps
object to have the new step number calculations and then moved theinputEntryPointSelection
and theinputTitle
entry methods to occur ahead of the credential collection.Directions for Reviewers
To validate, you should create deployments on the following, making sure a deployment can be created and that the step numbers update appropriately to your selections: [ ] a project with a single entry point, using an existing credential [ ] a project with a single entry point, creating a new credential [ ] a project with multiple entry points, using an existing credential [ ] a project with multiple entry points, using a new credential