posit-dev / publisher

MIT License
3 stars 0 forks source link

Show restore status in active publishing log display #1907

Open sagerb opened 3 days ago

sagerb commented 3 days ago

Intent

Resolves #1795

This PR updates the publishing log to show environment restoration status when a deployment is active.

It also updates the publishing progress dialog to show active message terminology rather than the older (considered inactive) verbs.

Type of Change

Approach

The event message utility method of eventMsgToString was updated to provide a verb appropriate to the actual message (in that the verb should reflect if that phase has been completed or is in progress - inActive or active). In doing this, a Record structure was switched to a Map, to better match our other implementations.

To be consistent between the deployProgress and the Publisher Log, the deployProgress component was switched to subscribe to and display the more generic message of restoreEnv rather than the language-specific messages of restorePythonEnv and restoreREnv.

In addition, two go files were updated when just fix was run against the branch. These files were unchanged and present within main for some time, without being flagged as missing their copyright headers. I'm not currently sure what's going on, but I'll add an issue to the triage board: (#1906)

Automated Tests

Directions for Reviewers

The best way to see the effect is to reset your test environment so that the Python and R environment restorations will require actual installations to occur.

Should verify deployment progress display and publishing log when a deployment is active as well as completed, for both R and Python projects.