posit-dev / publisher

MIT License
3 stars 0 forks source link

Add dir parameter to inspect api #1915

Closed mmarchetti closed 5 days ago

mmarchetti commented 5 days ago

Intent

This PR adds the new dir parameter to the /api/inspect endpoint, and adds projectDir to the response body. This changes the shape of the response, so there is a minimal frontend change to consume the new type.

Fixes #1851 Fixes #1844

Type of Change

Directions for Reviewers

Ensure that creating a new configuration (via inspection works. We do this in 3 places:

sagerb commented 5 days ago

I've verified that this code works great!

mmarchetti commented 5 days ago

Do the Go tests for the API need to be enhanced in any way to handle this change?

Ideally, yes. This endpoint is currently wiithout unit tests.