Open dotNomad opened 3 days ago
VSCode 1.91.0 added a new setting accessibility.underlineLinks which does what it says on the tin
1.91.0
accessibility.underlineLinks
To make links easier to distinguish from regular text in the workbench, you can enable the setting accessibility.underlineLinks to underline links.
https://code.visualstudio.com/updates/v1_91#_link-underlines
This PR ensures all of our text links (<a>) support the feature and toggle appropriately.
<a>
Resolves #1934
The injected CSS does the below
.monaco-workbench p>a { text-decoration: var(--text-link-decoration); }
The --text-link-decoration variable changes based on the setting.
--text-link-decoration
To support this, anywhere do an text anchor link we could use that CSS variable, or if it is text we can wrap the anchor in a p element. I did the latter here.
p
VSCode
1.91.0added a new settingaccessibility.underlineLinkswhich does what it says on the tinhttps://code.visualstudio.com/updates/v1_91#_link-underlines
This PR ensures all of our text links (
<a>) support the feature and toggle appropriately.Preview
https://github.com/posit-dev/publisher/assets/19917631/eb4d859f-7771-4c7f-a4ff-1cd501048800Intent
Resolves #1934
Type of Change
Approach
The injected CSS does the below
The
--text-link-decorationvariable changes based on the setting.To support this, anywhere do an text anchor link we could use that CSS variable, or if it is text we can wrap the anchor in a
pelement. I did the latter here.