Closes #1854 (Use selected Deployment's projectDir to list files and include/exclude)
Type of Change
[x] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Documentation
[ ] Refactor
[ ] Tooling
Approach
After everything was updated to pass in the projectDir from the activeContentRecord, adding and removing files from the config.Files section would not work correctly when the project was not located at the top root dir that VSCode had opened.
This was because the files API returned an ID that included the projectDir, and this was an incorrect value for the config file. I've created issue #1950, but this PR implements a simple workaround that removes the projectDir from the path represented in the id of a file.
Automated Tests
Directions for Reviewers
Make sure you can add and remove exclusions from the files view, with the selected configuration being updated, and the files view updating to show the result.
Also make sure you can update the config file directly, and the files view is updated correctly.
Need to verify this for both projects that are opened directly as well as projects that exist below the main folder opened within VSCode.
Intent
Closes #1854 (Use selected Deployment's
projectDirto list files and include/exclude)Type of Change
Approach
After everything was updated to pass in the projectDir from the activeContentRecord, adding and removing files from the config.Files section would not work correctly when the project was not located at the top root dir that VSCode had opened.
This was because the files API returned an ID that included the projectDir, and this was an incorrect value for the config file. I've created issue #1950, but this PR implements a simple workaround that removes the projectDir from the path represented in the id of a file.
Automated Tests
Directions for Reviewers
Make sure you can add and remove exclusions from the files view, with the selected configuration being updated, and the files view updating to show the result. Also make sure you can update the config file directly, and the files view is updated correctly.
Need to verify this for both projects that are opened directly as well as projects that exist below the main folder opened within VSCode.