posit-dev / publisher

MIT License
3 stars 0 forks source link

Relative file IDs #1963

Closed mmarchetti closed 2 months ago

mmarchetti commented 2 months ago

Intent

This PR changes the Files API's id field to be a path relative to the requested directory instead of the workspace root. It also removes the workaround introduced in #1954.

Fixes #1950

Type of Change

Automated Tests

Added a test for the case where the requested directory is a subdirectory of the root.

Directions for Reviewers

Run the VSCode extension, with a project and configuration file in a subdirectory of the root. Use the UI to exclude and include files; it should still work and the configuration file should show the paths correctly (relative to the project dir, not the workspace root).