posit-dev / publisher

MIT License
6 stars 1 forks source link

If a deployment fails before we can create anything on Connect, we still display an active `View Content` button #2373

Open kgartland-rstudio opened 1 month ago

kgartland-rstudio commented 1 month ago

If I try to deploy content to Connect but it fails before anything is created, under the failure message there's still a View Content button but it leads nowhere.

Here I was able to add the dogfood server using http:// rather than https:// and deploy but that deployment didn't result in content being created. However, we still show the View Content button which doesn't lead anywhere.

Image

sagerb commented 1 month ago

Based on a file refresh or manual refresh, we will be querying the status of content on the server. We can tie into this and disable the button if not possible.

dotNomad commented 1 week ago

Rather than relying on if the deployment record is in the pre-deployment state we can use the Connect API in a similar way to #2179