Allow for `TagAttrs` to accept a `Tag`'s `attrs`

posit-dev / py-htmltools

Tools for HTML generation and output

MIT License

19 stars 4 forks source link

Allow for `TagAttrs` to accept a `Tag`'s `attrs` #55

Closed schloerke closed 12 months ago

schloerke commented 1 year ago

[x] News
[x] Test

wch commented 12 months ago

I think a better way to go about this is to change TagAttrs from a Dict to a Mapping. (The reason it didn't accept a TagAttrDict as a TagAttrs object is because Dict is invariant, whereas Mapping is covariant.)

TagAttrs = Mapping[str, TagAttrValue]

There is also a place where you'll have to test for isinstance(x, Mapping) instead of isinstance(x, dict).