posit-dev / py-shiny

Shiny for Python
https://shiny.posit.co/py/
MIT License
1.32k stars 81 forks source link

bug(download): Properly namespace output_id for render.download in modules #1732

Closed nsiicm0 closed 1 month ago

nsiicm0 commented 1 month ago

Fixes https://github.com/posit-dev/py-shiny/issues/1724

schloerke commented 1 month ago

Thank you @nsiicm0 !!

michaelsong-vbu commented 1 month ago

The render.image also has similar issue. I cannot loop one render.image function and takes in multiple ids. Could you also help look into that? Thanks! @schloerke

schloerke commented 1 month ago

@michaelsong-vbu I do not readily see the issue. Do you mind opening a new issue with a shinkylive.io reprex (reproducible example)? Thank you!