search

posit-dev / r-shinylive

https://posit-dev.github.io/r-shinylive/
Other
151 stars 16 forks source link

Increasing download timeout #30

Closed dgkf closed 9 months ago

dgkf commented 10 months ago

My quarto presentations error with a utils::download.file timeout (defaults to 60s, expecting ~4MB/s for the 250MB shinylive archive). Not sure if it's limited by my internet or the github release artifacts server throttling downloads, but regardless this exceeds the guidelines in ?utils::download.file:

It is unrealistic to require download times of less than 1s/MB.

Just temporarily bumping the download timeout to accommodate the file size. Not sure how much you want to engineer this, but this could even catch the error and check to see if it failed due to a timeout, and if so suggest rerunning with R_DEFAULT_INTERNET_TIMEOUT increased.

schloerke commented 9 months ago

Thank you!

For now, we'll leave it as is. In the future, I'll update {httr}/{httr2} to retrieve the file so that a progress bar is displayed.