search

posit-dev / shiny-bindings

Monorepo containing Javascript packages that simplify the experience of writing custom bindings for Shiny apps
10 stars 2 forks source link

`selector` should default to `name` #4

Open schloerke opened 7 months ago

schloerke commented 7 months ago

Ex: https://github.com/posit-dev/shiny-bindings/blob/867dfed60f05c4134a0862d6e7559fd23bca4ad5/packages/react/src/makeReactInput.ts#L8

From https://github.com/posit-dev/shiny-bindings/commit/4738b86c3132aa7324db920dc9d3eda532471d82 , selector was added and it defaults to .{name}. Instead, I believe it should be {name} as you are making the component of type name and no class values are being added.

schloerke commented 7 months ago

@nstrayer If this seems like a valid bug, I'm happy to make a PR.

... just looking for confirmation.