posit-marketing / taylor-swift-tour

The Eras Tour told by numbers
https://colorado.posit.co/rsc/tay-swift-tour/
46 stars 9 forks source link

Leaflet "source" popups aren't clickable (?) #2

Closed jack-davison closed 11 months ago

jack-davison commented 11 months ago

Good afternoon,

This is an excellent demo of Quarto, thanks - learned a lot from it!

The {leaflet} map is really nice, but I'm a bit confused; the popups each have a "source" link, but I can't seem to click on them. As they're hover-labels, when you move your mouse towards "source" the hover closes. Should they be traditional popups, which linger rather than track the mouse, instead?

image

Cheers, Jack

ivelasq commented 11 months ago

Hi Jack, thanks for reaching out and we hope that you enjoyed the piece!

I have updated the map to use popups instead of labels, so you should be able to click the sources now. In case it's easier, the sources are also available in this CSV: https://github.com/posit-marketing/taylor-swift-tour/blob/main/data/taylor-economic-impact_geocoded.csv

jack-davison commented 11 months ago

That's great, thanks! Just wanted to make sure I wasn't missing something as to how {leaflet} labels worked, really!

Cheers

jack-davison commented 11 months ago

Hi Jack, thanks for reaching out and we hope that you enjoyed the piece!

I have updated the map to use popups instead of labels, so you should be able to click the sources now. In case it's easier, the sources are also available in this CSV: https://github.com/posit-marketing/taylor-swift-tour/blob/main/data/taylor-economic-impact_geocoded.csv

I'm not sure how impressed Scottish readers will be for labelling their capital as being in "England" though!

https://github.com/posit-marketing/taylor-swift-tour/blob/bade28f9747abf570ec98c54ef76edbab4394996/data/taylor-economic-impact_geocoded.csv#L18-L20

ivelasq commented 11 months ago

Whoops 🫣 sorry about that!