search

positive-js / mosaic

Angular components ✨ 📦🐣 ✨
https://mosaic.ptsecurity.com
MIT License
142 stars 39 forks source link

feat(docs) : new modal docs (#UIM-859) #791

Closed bogdanhpk closed 2 years ago

welcome[bot] commented 2 years ago

Congratulations on your first PR!

PositiveJS commented 2 years ago

Preview docs changes for e3cf729 at https://positive-js.github.io/mosaic-previews/pr791-e3cf729/

PositiveJS commented 2 years ago

Preview docs changes for 2da42d8 at https://positive-js.github.io/mosaic-previews/pr791-2da42d8/

agalaktionov commented 2 years ago

@bogdanhpk давай сюда добавим ссылку на гайд по валидации https://mosaic.ptsecurity.com/validation/overview image

Потерялся предлог image

PositiveJS commented 2 years ago

Preview docs changes for 85f693a at https://positive-js.github.io/mosaic-previews/pr791-85f693a/

PositiveJS commented 2 years ago

Preview docs changes for 4eaf937 at https://positive-js.github.io/mosaic-previews/pr791-4eaf937/

PositiveJS commented 2 years ago

Preview docs changes for 0cb34b4 at https://positive-js.github.io/mosaic-previews/pr791-0cb34b4/

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ptsecurity/mosaic/ERw3KPQQUXbpVTsPpFkz4eyQuJBo
✅ Preview: Failed

[Deployment for e1dc6e0 failed]

PositiveJS commented 2 years ago

Preview docs changes for abb15a2 at https://positive-js.github.io/mosaic-previews/pr791-abb15a2/

PositiveJS commented 2 years ago

Preview docs changes for e1dc6e0 at https://positive-js.github.io/mosaic-previews/pr791-e1dc6e0/

PositiveJS commented 2 years ago

Preview docs changes for a9a0893 at https://positive-js.github.io/mosaic-previews/pr791-a9a0893/

oburdasov commented 2 years ago

@lskramarov посмотри пожалуйста. Добавил логику для скрытия лишних масок в modal service + тест

PositiveJS commented 2 years ago

Preview docs changes for 25af842 at https://positive-js.github.io/mosaic-previews/pr791-25af842/

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

lskramarov commented 2 years ago

@agalaktionov добавил исправления от техрайтеров, посмотри еще раз, если все ок, поставь апрув.

PositiveJS commented 2 years ago

Preview docs changes for a7855b8 at https://positive-js.github.io/mosaic-previews/pr791-a7855b8/