FonbetBetting

[nadyr-mg]

Resolve #103

[ghost]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3d30767). Click here to learn what that means. The diff coverage is 70.3%.

@@            Coverage Diff            @@
##             master     #105   +/-   ##
=========================================
  Coverage          ?   91.38%           
=========================================
  Files             ?       28           
  Lines             ?     1893           
  Branches          ?        0           
=========================================
  Hits              ?     1730           
  Misses            ?      163           
  Partials          ?        0

Impacted Files	Coverage Δ
surebet/bookmakers.py	96% <100%> (ø)
surebet/main.py	63.79% <100%> (ø)
surebet/parsing/fonbet.py	98.73% <100%> (ø)
surebet/handling/surebets.py	98.38% <100%> (ø)
surebet/handling/calculating.py	100% <100%> (ø)
surebet/betting/fonbet.py	25.28% <25.28%> (ø)
surebet/loading/fonbet.py	86.66% <87.5%> (ø)
surebet/parsing/bets.py	98.11% <95.23%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d30767...e049167. Read the comment docs.

[ghost]

Move _init_ and other functions into class FonbetBet. Move package betting from handling to the main level

[nadyr-mg]

FonbetBet class is used in module parsing

[ghost]

Replace logging.info by logging.error Example:

if "requestId" not in res:
        logging.info(res)

[ghost]

Pass login and password to _init function. Create class FonbetBot, move _init function here as the contractor. Also, move other functions into this class

[nadyr-mg]

loading/fonbet.py: redundant variable URL_JSON line 62:

• instead of func random.uniform(0, 1), you can use random.random
• use format (e.g. "abc {arg1} ef {arg2}".format(arg1="d", arg2="g"))

line 68: there is built in func: "r_line.json()"

[nadyr-mg]

surebet/parsing/fonbet.py

• press ctrl+alt+L in pycharm (you can do it in all modified files)
• line 215: redundant "if" statement (it's always FonbetPartBets)
• line 220: variable "b" (naming)
• line 220: "if b in part.dict", b always in part.dict
• line 225: same as previous