positiveway / SureFinder

Surebet scanner and betting bot
28 stars 10 forks source link

DetailedSurebet #79

Closed nadyr-mg closed 6 years ago

nadyr-mg commented 6 years ago

Resolve #77

ghost commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ba7266e). Click here to learn what that means. The diff coverage is 98.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #79   +/-   ##
=========================================
  Coverage          ?   96.43%           
=========================================
  Files             ?       26           
  Lines             ?     1572           
  Branches          ?        0           
=========================================
  Hits              ?     1516           
  Misses            ?       56           
  Partials          ?        0
Impacted Files Coverage Δ
surebet/bookmakers.py 95.13% <100%> (ø)
surebet/main.py 96.55% <100%> (ø)
surebet/handling/detailed_surebets.py 97.87% <97.87%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba7266e...393ffb9. Read the comment docs.

ghost commented 6 years ago

remove \n in __str__, general output format will be in main move common part of pattern in separate variable " {profit:<8} | {sport:<6} | {book1:<6} | {ev_name1:<60} | part #{part} | "

ghost commented 6 years ago

move list(result) to filter function move lambda to separate function LIFETIME_LOW_LIM <= item.life_time -> item.life_time > LIFETIME_LOW_LIM Var should be compared with const

ghost commented 6 years ago

if first_profit != second_profit: return first_profit - second_profit else return first.lifetime - second.lifetime

ghost commented 6 years ago

add print of detailed surebets

ghost commented 6 years ago

rename filter_key -> predicate

ghost commented 6 years ago

add returned types of functions

ghost commented 6 years ago

redundant cast list(_filter(detailed_surebets))

ghost commented 6 years ago

move to function _sort_detailed as was said in issue

ghost commented 6 years ago

add end='\n' in print(detailed_surebet)

ghost commented 6 years ago

replace loop print: print(detailed_surebets, sep='\n')