Support all browsers for our extension

[posix4e]

Currently we only support IOS. Let's support chrome. Let's provide tests,ci and cd

[kernel-loophole]

hi there ,this is zulqarnain from replit .I have some question about it . What are the key features or functionalities that you would like to ensure work seamlessly in the Chrome version of the extension? Are there specific aspects of the JavaScript codebase that need to be adapted for Chrome compatibility? Are there any iOS-specific features that need to be adjusted? Looking forward to discuss more .

[posix4e]

I don’t think we should worry about breaking functionality. If it does break we should add a failing unit test . The existing logic is very trivial and only consists of a few html and js files. The real goal behind this issue is making a first stab on a working test and deploy framework

[kernel-loophole]

That's great.when you want this ready.

[posix4e]

When you can

[kernel-loophole]

2 weeks

[posix4e]

OkSent from my iPhoneOn Aug 19, 2023, at 22:19, Zulqarnain @.***> wrote: 2 weeks

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

[kernel-loophole]

great ,so i am sending proposal on replit .

[kernel-loophole]

can you accept my work on replit .

[posix4e]

You did tests, ci but not cd. You need to publish the extension as a zip file whenever a tag release event happens. Should be pretty easy now that we have ci working

[kernel-loophole]

so should i publish this to Chrome Web Store?

[posix4e]

If it’s easy enough, but that’s not required. What is required is a zip file being published on the tags/releases. Check the other examples in the .github repo that we do to publish apk files

[kernel-loophole]

jobs:
  sync-to-hub:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
          lfs: true
      - name: Push to hub
        env:
          HF_TOKEN: ${{ secrets.HF_TOKEN }}
        run:
          git push https://posix4e:$HF_TOKEN@huggingface.co/spaces/posix4e/puppet main

are you talking about this one .

[posix4e]

https://github.com/posix4e/puppet/blob/main/.github/workflows/release_ci.yml

[kernel-loophole]

okay i will update accordingly

[kernel-loophole]

anything else from my side .

[posix4e]

Once I test the released zip file I will give you feedback. I’m still working on it

[kernel-loophole]

okay

[posix4e]

Still no luck with the zip that’s created

[kernel-loophole]

is the zip file created on your end after releasing a tag ?.Because i release i tag it does not .

[kernel-loophole]

well uploading the extension to chrome locally work fine .

[posix4e]

Right the cd process should trigger when you push a tag

[kernel-loophole]

yeah i tried five to six time releasing a new tag and does not create the apk and also the zip extension.

[posix4e]

Did you try git tag vtest Git push origin vtest

[kernel-loophole]

no ,but let me try this .

[kernel-loophole]

but when i make a spirit yml file for zip extension tag release only then it work.

[posix4e]

What is a spirit Yml?

[kernel-loophole]

instead of putting the zip extension file yml commands in release.yml i make another file which is zip.yml which run whenever a new tag push .

[posix4e]

I don’t see any releases on your GitHub . Make it work on your repo and I will pull it over

[kernel-loophole]

i add the release tags .but i delete the repo and fork again .

[kernel-loophole]

i just release a new tag .now you can check.

[kernel-loophole]

okay let me add this first on my github repo .let you know when it work

[kernel-loophole]

hi,after changing it so many .and push the new tags .the zip file is not created .any suggestion about it .how can i fix this ?have a look on github repo

[kernel-loophole]

HI there ,i change the yml files and it's working fine .here is latest tag release which make both zip and apk file .both functionally are working.have a look and let me know .you can also check other release as well. https://github.com/kernel-loophole/puppet/releases/tag/Releasev0.5.26

[kernel-loophole]

Hi I am unable to message ok replit.there is mini comma issue in manifest.json .