Llm adblock - Githubissues

posix4e commented 1 year ago

I haven't carefully reviewed yet, but it looks like we an amazing start.

Ported from https://github.com/posix4e/puppet/pull/45.

TODO

[x] Basic python end to end test acceptance test showing it working
[x] Basic java unit tests for the internal logic
[x] Basic Java end to end test acceptance test showing it working
[x] allow gradio to use gpt4all
[x] Get rid of any direct calls to openai, and switch everything over to gpt4all

posix4e commented 1 year ago

Ported from https://github.com/posix4e/puppet/pull/45

github-actions[bot] commented 1 year ago

LOGAF Level 3 - /home/runner/work/puppet/puppet/backend/models.py

The User model has a name field with a server default of "Default name". This could lead to confusion if a user is created without a name. Consider making the name field required.
The __repr__ methods are not returning valid strings. This could lead to errors when trying to print the objects. Make sure to return valid strings.

Example:

def __repr__(self):
    return f"User(id={self.id}, name={self.name}, uid={self.uid})"

LOGAF Level 2 - /home/runner/work/puppet/puppet/tests/test_sauce_labs.py

1. Code Duplication: There is a lot of code duplication in the save_server_settings and enable_accessibility_settings functions. You can create a helper function to find and click an element by ID or XPATH. This will make your code DRY (Don't Repeat Yourself) and easier to maintain.

Example:

def find_and_click_element(driver, by_selector, selector_value):
    element = find_and_click(driver, by_selector, selector_value)
    return element

2. Hardcoded Values: The server URL is hardcoded in the save_server_settings function. It's better to move this to a configuration file or environment variable.

3. Unnecessary Comments: There are several comments in the code that do not add value or explain complex code. Removing these comments can improve code readability.

4. Magic Strings: There are several strings that are used multiple times throughout the code (e.g., AppiumBy.ID, AppiumBy.XPATH). Consider defining these as constants at the top of your file.

5. Unused Code: There are several lines of code that are commented out. If this code is not needed, it should be removed to improve readability.

LOGAF Level 2 - /home/runner/work/puppet/puppet/backend/backend.py

Avoid using print statements for logging. Use a logging library instead. This will give you more control over your logs and you can easily switch between different levels of logging.
The openai_key is being stored in the User model. This could be a potential security risk if the database is compromised. Consider using a more secure method to store sensitive data.
The add_command function commits to the database for each new command. This could be inefficient if there are many commands. Consider adding all the commands first and then commit once.

Example:

commands = [Command(uid=item.uid, command=cmd) for cmd in command_list]
db.add_all(commands)
db.commit()

The send_event function opens a file for each event. This could be inefficient if there are many events. Consider opening the file once and writing all the events.

Example:

with open(f"{item.uid}_events.txt", "a") as f:
    for event in events:
        f.write(f"{datetime.now()} - {event}\n")

🔒🔁🧹

Powered by Code Review GPT

urbit-pilled commented 1 year ago

looks like saucelabs is still using the old apk file in the E2E tests and it looks like the E2E tests gets triggered twice (push and pull_request)