search

posix4e / rust-metrics

Multi reporter metrics library (carbon, graphite, postgresql, prometheus)
Other
99 stars 19 forks source link

Move to autogenerated promo_proto.rs #51

Closed overvenus closed 8 years ago

overvenus commented 8 years ago

Hello @posix4e

Do you have any plan when promo_proto.rs will be added?

I found rust-metrics can not be compile even after disabled prometheus, cargo reports error: file not found for module 'promo_proto'

Here is my Cargo.toml

[dependencies.metrics]
git = "https://github.com/posix4e/rust-metrics.git"

I dont want use v0.1.1 in crate.io, because master branch has changed many place, and it breaks v0.1.1 API.

I can send a PR to fix this issue if you want.

posix4e commented 8 years ago

Prometheus isn't stable yet. It should be disabled by default. On Tue, Jul 12, 2016 at 4:16 AM Neil Shen notifications@github.com wrote:

Hello @posix4e https://github.com/posix4e

Do you have any plan when promo_proto.rs will be added?

I found rust-metrics can not be compile even after disabled prometheus, cargo reports error: file not found for module 'promo_proto'

Here is my Cargo.toml

[dependencies.metrics]git = "https://github.com/posix4e/rust-metrics.git"

I dont want use v0.1.1 in crate.io, because master branch has changed many place, and it breaks v0.1.1 API.

I can send a PR to fix this issue if you want.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/posix4e/rust-metrics/issues/51, or mute the thread https://github.com/notifications/unsubscribe/AAxN2x2PwVtSil9P1MhWEG4xRntrcApQks5qU3ejgaJpZM4JKScu .

Sent from my mobile 4045076749 Alex Newman

posix4e commented 8 years ago

I'd be interested in your fix.

On Tue, Jul 12, 2016 at 4:16 AM Neil Shen notifications@github.com wrote:

Hello @posix4e https://github.com/posix4e

Do you have any plan when promo_proto.rs will be added?

I found rust-metrics can not be compile even after disabled prometheus, cargo reports error: file not found for module 'promo_proto'

Here is my Cargo.toml

[dependencies.metrics]git = "https://github.com/posix4e/rust-metrics.git"

I dont want use v0.1.1 in crate.io, because master branch has changed many place, and it breaks v0.1.1 API.

I can send a PR to fix this issue if you want.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/posix4e/rust-metrics/issues/51, or mute the thread https://github.com/notifications/unsubscribe/AAxN2x2PwVtSil9P1MhWEG4xRntrcApQks5qU3ejgaJpZM4JKScu .

Sent from my mobile 4045076749 Alex Newman

overvenus commented 8 years ago

I have disabled prometheus, but still cargo can not compile rust-metrics.

My patch is simple, add the generated prome_proto.rs.

posix4e commented 8 years ago

@overvenus you should be unblocked now

overvenus commented 8 years ago

Thank you!

In the feature, we plan to use prometheus in tikv, a distributed transactional key value database powered by Rust and Raft.