search

posixpascal / phpmemcacheadmin

memcached monitor
0 stars 0 forks source link

Uptime of "All servers" is sum of uptime of servers #5

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
When looking at the uptime of each of my server, I have something like:
 Uptime 143 days 8 hrs 11 min

But when looking at the same stat in 'All servers', I have the following:
 Uptime 860 days 3 hrs 39 min

It appears phpmemcacheadmin is summing the uptime of the 6 servers

Original issue reported on code.google.com by colin.pi...@gmail.com on 3 Dec 2010 at 5:09

GoogleCodeExporter commented 8 years ago 
Easy to patch:

in Library/Analysis.php line 48:
            if(isset($array[$key]) && ($key != 'version') && ($key != 'uptime'))

instead of 
            if(isset($array[$key]) && ($key != 'version'))

Original comment by colin.pi...@gmail.com on 3 Dec 2010 at 5:26

GoogleCodeExporter commented 8 years ago 
I will remove version too, as it take first or last server's version ^^

Original comment by eli...@free.fr on 6 Dec 2010 at 1:40

GoogleCodeExporter commented 8 years ago 
For version, it could display one if all servers are the same version and 
"heterogeneous" in case they are different. For the uptime, it's true it 
doesn't really make sense ...

Original comment by colin.pi...@gmail.com on 6 Dec 2010 at 3:10

GoogleCodeExporter commented 8 years ago 
Here is a quick patch for this.

Original comment by colin.pi...@gmail.com on 12 Jan 2011 at 10:27

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
I close this enhancement as version 1.2.0 is out today 

Thank you for providing this patch

http://code.google.com/p/phpmemcacheadmin/downloads/list

Original comment by eli...@free.fr on 6 Apr 2011 at 8:57