posixru / batti-gtk

Automatically exported from code.google.com/p/batti-gtk
GNU General Public License v2.0
0 stars 1 forks source link

Improve internationalization of batti #9

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Use getextplurals for i18n
https://gitorious.org/batti/batti/blobs/master/src/Battery.py
Lines 184 - 195

More info on gettext plurals
http://www.gnu.org/s/hello/manual/gettext/Plural-forms.html

Missing gettext on strings below, so they are not in POT:

https://gitorious.org/batti/batti/blobs/master/src/BatteryMonitor.py
Lines 45 - 57

https://gitorious.org/batti/batti/blobs/master/src/Constants.py
Line 22

http://gitorious.org/batti/batti/blobs/master/src/Notificator.py
Line 87

http://gitorious.org/batti/batti/blobs/master/batti
Lines 27, 36, 43

Original issue reported on code.google.com by cjlhomea...@gmail.com on 22 Jun 2011 at 3:02

GoogleCodeExporter commented 8 years ago
Attached is a patch that I think addresses these various issues.

Original comment by walter.b...@gmail.com on 22 Jun 2011 at 12:36

Attachments:

GoogleCodeExporter commented 8 years ago
Can this patch be reviewed applied? It is not particularly invasice, so it 
shouldn't require a huge amount of effort.

Original comment by cjlhomea...@gmail.com on 6 Sep 2011 at 3:40

GoogleCodeExporter commented 8 years ago
From looking at a recent POT file, it looks like this has been addressed.  This 
bug can be closed, except for one thing

#: src/Battery.py:189
#, python-format
msgid "%d Hour"
msgid_plural "%d Hours"
msgstr[0] ""
msgstr[1] ""

#: src/Battery.py:189
#, python-format
msgid "%d Minutes"
msgid_plural "%d Minutes"
msgstr[0] ""
msgstr[1] ""

This line
msgid "%d Minute" (should be made singular)

Thanks.

cjl

Original comment by cjlhomea...@gmail.com on 6 Aug 2012 at 2:49