OMK created OSM files with tags of null values

posm / OpenMapKitAndroid

http://openmapkit.org

BSD 3-Clause "New" or "Revised" License

128 stars 38 forks source link

OMK created OSM files with tags of null values #10

Closed skorasaurus closed 9 years ago

skorasaurus commented 9 years ago

Hi,

Awesome work!

I noticed in one of the pictures in Dale's presentation this morning was an OSM file in JOSM. In the picture that was created in OMK and opened in josm, contained buildings had several tags which had an empty or null value in them.

Here was an example of what I'm trying to explain except there would be nothing there where the 0's are. (you can't manually add a tag with a null value in JOSM). selection_039

cc @dalekunce

dalekunce commented 9 years ago

@skorasaurus thanks for pointing this out. One of our next sprints is going to be on constraints. We will be driving to have OMK use a lot of the same constraint logic as ODK with a slight OSM bent. Check back in a few weeks.

hallahan commented 9 years ago

Good catch, this is an easy fix.

We need to check to see if a value is null in the XML Writer here:

https://github.com/AmericanRedCross/openmapkit/blob/master/MapboxAndroidSDK/src/main/java/com/spatialdev/osm/model/OSMElement.java#L152