search

posm / OpenMapKitAndroid

http://openmapkit.org
BSD 3-Clause "New" or "Revised" License
128 stars 38 forks source link

OMK Android may send wrong OSM XML file to ODK Collect in intent #128

Open hallahan opened 8 years ago

hallahan commented 8 years ago

This is an edge-case bug, and it has only been seen to happen once. Basically, the file name of the OSM XML edit is different between what is written to the ODK Collect directory and what is sent back to ODK Collect via intents. This causes an inconsistency on the server as seen here:

screen shot 2016-03-04 at 4 10 19 pm

On the server piece, there is middleware that rewrites the submission JSON when it finds a matching media attachment in the submission's directory. In this case, it did not find that match, so it didn't do the rewrite. This is not a server problem, it is an OMK Android problem. The correct file was not sent.

My guess is that this is a bug caused by some unusual user flow in OMK Android. Maybe the user had selected a different OSM element from what was being edited at the time of save?

Further investigation will have to go into trying to recreate this bug.

cc/ @danbjoseph

hallahan commented 8 years ago

Fixing #115 will probably fix this.