search

posm / OpenMapKitAndroid

http://openmapkit.org
BSD 3-Clause "New" or "Revised" License
128 stars 38 forks source link

Constraints Form JSON should be named by Form ID, not Form Title #150

Closed hallahan closed 8 years ago

hallahan commented 8 years ago

Unfortunately, ODK is inconsistent with the form file name, the form id, and the form title.

ODK Collect stores forms by their form title. ODK Aggregates and also the XForms XML itself calls a form_id by the form_id specified in your XLS settings tag. But, JavaRosa's FormDef which supplies a form id is an integer value.

That form id is what gets to OMK Android via intents, but this number isn't very useful, because it isn't the form ID we know and love.

So, for now, we're just going to have to name our constraint JSON file by the form title. That's the file name used on the file system in ODK Collect. It doesn't really matter, but it's an inconsistency.

screenshot 2016-05-16 14 49 00

This change will require modification in JavaRosa and ODK Collect.

Encountered during implementation of #147 and #148 via constraints sprint #117.

hallahan commented 8 years ago

For creating a constraints JSON file, we should just document this I think...

hallahan commented 8 years ago

Will be documented.