posm / OpenMapKitAndroid

http://openmapkit.org
BSD 3-Clause "New" or "Revised" License
128 stars 38 forks source link

Hidden Required Tags #158

Open jasonrogena opened 7 years ago

jasonrogena commented 7 years ago

Required tags that are hidden due to hide_if and show_if constraints remain required even when hidden. Users are unable to save data to ODK in such scenarios as the "There are n required tags that you need to complete" snackbar shows for the hidden tags.

hallahan commented 7 years ago

Ah, good catch.

hallahan commented 7 years ago

I'd say if the tag is required, never hide it.

jasonrogena commented 7 years ago

OK, cool. It's just that we deal with some scenarios where if a question is displayed using show_if or hide_if, the user is required to answer it.

hallahan commented 7 years ago

Or, you could put logic in where if a required tag is hidden, it's not required. That sounds reasonable to me.