search

posm / OpenMapKitAndroid

http://openmapkit.org
BSD 3-Clause "New" or "Revised" License
128 stars 38 forks source link

Openmapkit custom xml coloring #79

Closed imwongela closed 8 years ago

imwongela commented 8 years ago

This follows on the request to remove custom coloring from the Mapbox Android SDK. I have moved the files to a separate folder within the openmapkit app. I will be happy to get your views on this @hallahan Thanks

hallahan commented 8 years ago

I'm thinking we should revisit this with the new POI merge I'm doing. My thought is that we want to not make new classes like OSMColorPolygon. We want to add some methods to OSMPolygon and OSMLine to allow setting the color of the OSMLine or OSMPolygon.

We would want to add setters as well as add constructors that provide color parameters.

You should be able to set the color via a, r, g, b as well as color ints.

Take a look at Color docs:

http://developer.android.com/reference/android/graphics/Color.html

So to be clear, this sort of thing would modify the MapboxAndroidSDK. That is ok. While working on this, let me take a look at how you are doing it.

Once again, I apologize for taking so long to respond.