search

posm / OpenMapKitAndroid

http://openmapkit.org
BSD 3-Clause "New" or "Revised" License
128 stars 38 forks source link

numbering system for osm_building value for new POIs? #97

Closed danbjoseph closed 8 years ago

danbjoseph commented 8 years ago

If each device follows the same numbering schema for new POIs is the compiled data going to have multiple entries with osm_building = OSMNode-1.osm ?

mberg commented 8 years ago

These should probably be time stamped

See: https://github.com/AmericanRedCross/OpenMapKit/issues/92

On Sun, Nov 15, 2015 at 2:00 PM, Dan Joseph notifications@github.com wrote:

If each device follows the same numbering schema for new POIs is the compiled data going to have multiple entries with osm_building = OSMNode-1.osm ?

— Reply to this email directly or view it on GitHub https://github.com/AmericanRedCross/OpenMapKit/issues/97.

danbjoseph commented 8 years ago

on one device, the numbering restarted.... after sending completed forms? i don't think i closed out the app at any point.

screen shot 2015-11-15 at 5 05 55 pm
mberg commented 8 years ago

Sorry these are for new poi's i got confused.

On Sun, Nov 15, 2015 at 2:08 PM, Dan Joseph notifications@github.com wrote:

on one device, the numbering restarted.... after sending completed forms? i don't think i closed out the app at any point. [image: screen shot 2015-11-15 at 5 05 55 pm] https://cloud.githubusercontent.com/assets/4806884/11168484/566adcfc-8bbb-11e5-87fb-d8d72956f1cf.png

— Reply to this email directly or view it on GitHub https://github.com/AmericanRedCross/OpenMapKit/issues/97#issuecomment-156802459 .

hallahan commented 8 years ago

Negative values are used as a placeholder within a given changeset to uniquely identify a new element. This is how JOSM and iD work.

Since entries are simply concatenated, this is a problem. This would be a responsibility for the server, and this should be an issue on the server repo, not the Android app.

Simply time stamping the name of the files is not going to affect what happens on the OSM api. The API will still get confused by seeing multiple nodes with the same negative ID.

hallahan commented 8 years ago

aggregate-osm.js takes care of this. Also, we're adding timestamps to file name now. See #92.