search

posm / posm-carto

A simple CartoCSS style for POSM, highlighting HDM features.
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

admin boundaries #5

Closed dalekunce closed 8 years ago

dalekunce commented 8 years ago

admin boundaries didn't seem to be included in the style

almccon commented 8 years ago

Oops, those are easy to forget when you're mainly testing on extracts. Which admin levels would you find most useful? Or should we show all of them?

And do the different admin levels needs to be easily distinguishable, or can they all use basically the same styling?

On Mar 13, 2016, at 18:28, Dale Kunce notifications@github.com wrote:

admin boundaries didn't seem to be included in the style

— Reply to this email directly or view it on GitHub.

almccon commented 8 years ago

I just added some quick (and unlabeled) admin boundaries, down to admin_level=8. Right now they're just a gray dashed line. Let me know how these work in the field and I'm happy to tweak them.

screen shot 2016-03-13 at 10 40 58 pm
almccon commented 8 years ago

Sounds like there were no complaints about these from the field.

dalekunce commented 8 years ago

can you add the higher level admins (admin0-admin6) these are missing and make regional way finding difficult.

almccon commented 8 years ago

They should already be enabled. admin0 gets a solid black line, and all the others have the same dashed gray. I'll admit it's not pretty (and I'll give them another styling pass) but they should be in there as of March 13.

I'm using geofabrik extracts for testing the style. Maybe the POSM extract pipeline is dropping borders somewhere?

almccon commented 8 years ago

Here's what I see with an Ecuador extract, zoomed way out:

screen shot 2016-04-19 at 19 apr 11 30 07

dalekunce commented 8 years ago

yeah maybe the posm extract dropped the data somehow. That looks good enough for me. :)