posquit0 / Awesome-CV

:page_facing_up: Awesome CV is LaTeX template for your outstanding job application
LaTeX Project Public License v1.3c
23.03k stars 4.79k forks source link

Why so many vspace commands? #123

Open gotgenes opened 7 years ago

gotgenes commented 7 years ago

Throughout the class file there are a number of entries that invoke a negative vspace command, some immediately after adding positive vspace in the first place. For example

% Define a subsection for CV
% Usage: \cvsubsection{<subsection-title>}
\newcommand{\cvsubsection}[1]{%
  \vspace{\acvSectionContentTopSkip}
  \vspace{-3mm}
  \subsectionstyle{#1}
  \phantomsection

has the effect of no net vspace added. \acvSectionContentTopSkip is defined as 3mm, which is the same amount of space removed by \vspace{-3mm}. So why not omit all vspace calls entirely?

Similarly

% Define a paragraph for CV
\newenvironment{cvparagraph}{%
  \vspace{\acvSectionContentTopSkip}
  \vspace{-3mm}
  \paragraphstyle
}{%
  \par
  \vspace{2mm}
}

has the same thing.

Is there a reason behind this?

johannesbottcher commented 7 years ago

the class needs some fixes.

Am 19.04.2017 07:36 schrieb "Chris Lasher" notifications@github.com:

Throughout the class file there are a number of entries that invoke a negative vspace command, some immediately after adding positive vspace in the first place. For example

% Define a subsection for CV % Usage: \cvsubsection{} \newcommand{\cvsubsection}[1]{% \vspace{\acvSectionContentTopSkip} \vspace{-3mm} \subsectionstyle{#1} \phantomsection

has the effect of no net vspace added. \acvSectionContentTopSkip is defined as 3mm, which is the same amount of space removed by \vspace{-3mm}. So why not omit all vspace calls entirely?

Similarly

% Define a paragraph for CV \newenvironment{cvparagraph}{% \vspace{\acvSectionContentTopSkip} \vspace{-3mm} \paragraphstyle }{% \par \vspace{2mm} }

has the same thing.

Is there a reason behind this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/posquit0/Awesome-CV/issues/123, or mute the thread https://github.com/notifications/unsubscribe-auth/AH4EjuHG1krGNE6CeO8MDnr_1UXTMkPOks5rxZ13gaJpZM4NBOD8 .