search

posquit0 / Awesome-CV

:page_facing_up: Awesome CV is LaTeX template for your outstanding job application
LaTeX Project Public License v1.3c
23.03k stars 4.79k forks source link

Allow https:// for urls in \homepage #126

Open BafDyce opened 7 years ago

BafDyce commented 7 years ago

Up to now, the template always inserted a 'http://' in the url for the \homepage{} attribute. Therefore, it was not possible to specify 'https://example.com' as this would have resulted in 'http://https://example.com'.

The new approach allows to specify the homepage-url in any of the following ways (which will result in the specified strings)

url provided to \homepage hyperlink displayed url-text
http://example.com http://example.com example.com
https://example.com https://example.com example.com
example.com http://example.com example.com

Note that the third row is equivalent to the current behavior.

posquit0 commented 7 years ago

Good idea! I'll review and merge your PR ASAP. Thanks.

BafDyce commented 7 years ago

Just a quick thought I had in the morning: It might be more suitable if I'd do the string manipulation inside the \newcommand (line 288) instead of where I've included it right now.

The current approach would require the same if-else structure whenever we want to do something with \homepage. (so, e.g. if someone would like to include the information somewhere else in the cv again he'd need to copy the code). I think it would be cleaner to modify the command so that it takes one argument and provides two named arguments (e.g. \@homepageUrl and \@homepageText). I'm just not 100% sure if this will work as I expect.

However, I can try to do this in the afternoon?

ericswpark commented 1 year ago

Will this fix the bug where https:// is rewritten to https//? The colon is removed for some reason in the linked URL, which causes a DNS resolver issue.