search

posquit0 / Awesome-CV

:page_facing_up: Awesome CV is LaTeX template for your outstanding job application
LaTeX Project Public License v1.3c
23.03k stars 4.79k forks source link

Fix font-not-found error #191

Closed cbarrick closed 5 years ago

cbarrick commented 6 years ago

Latex gives a font-not-found error if FontAwesome is not installed globally.

The problem, as far as I can tell, is that fontawesome.sty declares the FontAwesome family with \newfontfamily{\FA}{FontAwesome}. This does not point fontspec to the proper font directory.

However, awesome-cv.cls also declares the FontAwesome family with \newfontfamily\FA[Path=\@fontdir]{FontAwesome}. This does point to the proper font directory (\@fontdir), so the declaration in fontawesome.sty is unneeded.

This closes #181

johannesbottcher commented 6 years ago

what i just said in #181, you cannot just change a file.

Am 06.02.2018 03:19 schrieb "Chris Barrick" notifications@github.com:

Latex gives a font-not-found error if FontAwesome is not installed globally.

The problem, as far as I can tell, is that fontawesome.sty declares the FontAwesome family with \newfontfamily{\FA}{FontAwesome}. This does not point fontspec to the proper font directory.

However, awesome-cv.cls also declares the FontAwesome family with \newfontfamily\FA[Path=\@fontdir]{FontAwesome}. This does point to the proper font directory (\@fontdir), so the declaration in fontawesome.sty is unneeded.

This closes #181 https://github.com/posquit0/Awesome-CV/issues/181

You can view, comment on, or merge this pull request online at:

https://github.com/posquit0/Awesome-CV/pull/191 Commit Summary

  • Fix font-not-found error

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/posquit0/Awesome-CV/pull/191, or mute the thread https://github.com/notifications/unsubscribe-auth/AH4EjmYBagV4qWag129uWRmpiSwQIveDks5tR7a0gaJpZM4R6Zdp .

cbarrick commented 6 years ago

You cannot just change a copyrighted file.

I'm not sure I follow.

@posquit0 is claiming copyright on this file, so he has the authority to merge the PR. He has also given us express permission to use and modify this LaTeX template.

I can see this being less than an ideal fix. Breaking the font family definition out of the font's package seems gross. I'm open to other ways of solving the problem.

duesenfranz commented 6 years ago

@cbarrick while you seem to be right, I'm not sure, legally seen, how @posquit0 could claim copyright on a file which originally seems to be written by @plorcupin.

Unfortunately, there is no license in plorcupine/latex-fontawesome.

Maybe @posquit0 should chime in....

xuxiaoxia8385 commented 4 years ago

My error is well fixed by removing the declaration in fontawesome.sty. Thanks!