search

posquit0 / Awesome-CV

:page_facing_up: Awesome CV is LaTeX template for your outstanding job application
LaTeX Project Public License v1.3c
23.03k stars 4.79k forks source link

Added command for inline hyperlinks #228

Open TheGrandmother opened 6 years ago

TheGrandmother commented 6 years ago

Added this command to provide nice inline hyperlinks for when you are uncertain if the person reading your CV will have any technical knowledge :p

TheGrandmother commented 6 years ago

Oh and btw, Didnt update the example, Do you want me to include it in the example just tell me and I'll fix it.

johannesbottcher commented 6 years ago

I am wondering why people keep adding stuff. Where is mentioned that PRs are welcome? I am so confused.

On Thu, 30 Aug 2018, 11:35 Henrik Sommerland, notifications@github.com wrote:

Oh and btw, Didnt update the example, Do you want me to include it in the example just tell me and I'll fix it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/posquit0/Awesome-CV/pull/228#issuecomment-417256117, or mute the thread https://github.com/notifications/unsubscribe-auth/AH4EjkA9tOrjyPOCsIp4R2y2QKBhH9gQks5uV7H9gaJpZM4WTHrF .

TheGrandmother commented 6 years ago

Because it is released under an opensource licence and hosted on github. It is not explicitly stated that PRs are not welcome so most people will assume that they are welcome. But fine if you don't want people to improve it I'll just pull the changes into my fork.

johannesbottcher commented 6 years ago

I am not the one to decide if the PR is merged. There have been three (iirc) pull requests to add a Facebook link. Other PR for similar things and none was approved. I am just wondering.

On 30 Aug 2018 11:49, "Henrik Sommerland" notifications@github.com wrote:

Because it is released under an opensource licence and hosted on github. It is not explicitly stated that PRs are not welcome so most people will assume that they are welcome. But fine if you don't want people to improve it I'll just pull the changes into my fork.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/posquit0/Awesome-CV/pull/228#issuecomment-417260668, or mute the thread https://github.com/notifications/unsubscribe-auth/AH4EjupNsB63je5Xc42i0SG8nzyAT77vks5uV7VFgaJpZM4WTHrF .

TheGrandmother commented 6 years ago

Sorry, assumed you were the maintainer for some unknown reason. It's still the default though to try to improve OSS projects. The facebook rellated PRs haven't even been reviewed from what I can tell.

It's most likely just that the maintainer doesn't have time to review/actively maintain the project.

@posquit0 Do you want any help maintaining it?

bharatchavdaa commented 2 years ago

@TheGrandmother can you give an example of how does this look? And what changes we need to make in the .tex file.

(I am assuming this is the feature to add links whereever we want in a paragraph or a line right?)