Open cxkoda opened 4 years ago
I think that the pdfs are a huge benefit because they give a proper preview. The examples might also not build right out of the box (on Windows).
I agree the pdfs are very nice for the preview. But they bloat the whole repository, especially since the have to be rebuilt and updated after every change.
This can be avoided if we build the pdfs through the ci-pipeline and set links in the readme accordingly. Check out my pull request, or the master branch of my fork if you are interested how this would look like.
edit: typo
That makes a ton of sense to me. If said examples are still readily viewable (since that's what draws new people in / gets them interested).
For demonstration I set the links in the readme of my fork to point to the respective circle-artifacts (e.g. https://circleci.com/api/v1.1/project/github/cxkoda/Awesome-CV/latest/artifacts/0/~/results/examples/resume.pdf?branch=master&filter=successful), which are rebuild by the ci-pipeline after every push.
To keep the repository tidy I suggest removing the pdfs entirely from the repository.
Since they are obtained directly from building they add no additional information and should hence not be part of the repository. Instead they pdfs should be obtained from the ci-pipeline.
What do you think?