search

posquit0 / Awesome-CV

:page_facing_up: Awesome CV is LaTeX template for your outstanding job application
LaTeX Project Public License v1.3c
22.73k stars 4.75k forks source link

Fixed font awesome overleaf display issue #343

Open jensschaefer opened 3 years ago

jensschaefer commented 3 years ago

Corrected fa-symbol for phone, not displayed correctly in overleaf.

OJFord commented 2 years ago

Can you elaborate on 'not displayed correctly'?

Since mobile and phone are different icons, I don't really want to suddenly change it for someone who may be seeing it render correctly.

jensschaefer commented 2 years ago

I realized, I had misinterpreted the icon back in the day and introduced the phone icon for the sake of consistency.

Bildschirmfoto 2021-12-13 um 15 16 00

With the phone icon the top bar looked more consistent.

Bildschirmfoto 2021-12-13 um 15 20 25

The displayed icon looks more like mobile-alt. I think the actual mobile icon would fit here even better.

OJFord commented 2 years ago

I think it maybe is a better fit, and it seems more visually consistent with the email icon, I'm just not crazy about suddenly changing that for anyone using it when they update (maybe they liked the old one).

How do you feel about that @posquit0, and versioning/'breaking changes' as it were in general?

antenore commented 2 years ago

If I can add my opinion, I prefer the icon proposed by @jensschaefer On the other side, who doesn't like the default icon, is free to change it in the cls file.

antenore commented 2 years ago

To clarify it further. I'd merge this request and those that do not like it can always change the awesome-cv.cls file.

OJFord commented 2 years ago

This has also come up in #418, and as I described there think I'm inclined to keep them the same but make it more easily editable as in #420.