search

posquit0 / Awesome-CV

:page_facing_up: Awesome CV is LaTeX template for your outstanding job application
LaTeX Project Public License v1.3c
22.73k stars 4.75k forks source link

Changed 'gray' to 'graytext' in two instances #348

Closed Maroko closed 2 years ago

Maroko commented 3 years ago

Changed the color of the subsections from gray to graytext. Now it's possible to change the color of the cover letter subsection text. Before it was always gray (5D5D5D).

Maroko commented 3 years ago

Changed the cv section and the lettersection from "graytext" to "gray", so that the color scheme is more consistent between the cover letter and the cv (in the cv the cv items are colored "text")

OJFord commented 2 years ago

Is this redundant with #387? Seems like it might be more of a workaround for the same issue fixed there?

Maroko commented 2 years ago

387 fixes this PR issue partially. The text color is fixed, but the letter section dividers are still hardcoded to gray.

Colors for testing:

\definecolor{darktext}{HTML}{FF0000} \definecolor{text}{HTML}{0000FF} \definecolor{graytext}{HTML}{00FF00} \definecolor{lighttext}{HTML}{FFFF00}

Without my PR: grafik

With my PR: grafik

If there is another way to change the colors of the dividers, you can close this PR.

OJFord commented 2 years ago

I see, thanks. My concern with this is that it's a breaking change - even for users with unmodified colours this results in a change, which (even though it would just be shades of grey) I think is not a good idea to do in principle.

Could you add an option specifically for this dividing line, so that it's unchanged for existing users and just a new option? I'd be happy to merge that.

Maroko commented 2 years ago

Now it should do the trick.