search

posquit0 / Awesome-CV

:page_facing_up: Awesome CV is LaTeX template for your outstanding job application
LaTeX Project Public License v1.3c
22.43k stars 4.72k forks source link

Font Awesome 5 cleanup #399

Closed xaviermawet closed 2 years ago

xaviermawet commented 2 years ago

Hi, fontawesome.sty has been removed and replaced with the use of the fontawesome5 package since #344. Therefore, the font file fonts/FontAwesome.ttf as well as the definition of the font family FA can also be removed.

At the time of writing, the version of the font file fonts/FontAwesome.ttf is 4.7.0 and has not been updated for over 5 years while the fontawesome5 package has been updated "recently" and is based on Font Awesome 5.15.3.

xaviermawet commented 2 years ago

Hi @OJFord, Should I create another pull request to bypass the welcome action fail or do you have the option to replay actions/checks once #400 is merged ? Regards

OJFord commented 2 years ago

No worries, not needed for merge - it's just intended to add a comment saying thanks for PR will review soon 🙂.