search

posquit0 / Awesome-CV

:page_facing_up: Awesome CV is LaTeX template for your outstanding job application
LaTeX Project Public License v1.3c
22.28k stars 4.71k forks source link

Updated to use Font Awesome 6 #418

Open xaviermawet opened 2 years ago

xaviermawet commented 2 years ago

Hi,

This pull request adds latex commands for Font Awesome 6.1.1 free icons (inspired by #258 and #235).

Since there is no official FontAwesome6 package yet, I created a node application (latex-fontawesome) that consumes the Font Awesome GraphQL API to get icons metadata and generate definitions (sty file). Logic is based on plorcupine's latex-fontawesome project.

Steps in order to use icons from so-generated fontawesome6.sty file:

  1. Use search on the official website to find icon by name or related tags.
  2. Use unicode of the desired icon to search for latex definition in fontawesome6.sty.
  3. Copy and paste the associated definition in your latex document.
github-actions[bot] commented 2 years ago

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

OJFord commented 2 years ago

I've only quickly skimmed, but based on that the bot's comment seems unreasonable! Thanks for the PR, will look properly shortly.

github-actions[bot] commented 2 years ago

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

github-actions[bot] commented 2 years ago

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

xaviermawet commented 2 years ago

I'm certainly in favour of keeping the dependency up to date, but I'm not sure how I feel about bundling it rather than using a version published on CTAN.

Have you considered publishing yours?

I've never created or published a package on CTAN. I'm gonna try to do it and thus update my PR

github-actions[bot] commented 2 years ago

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

github-actions[bot] commented 2 years ago

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

github-actions[bot] commented 2 years ago

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

OJFord commented 1 year ago

Any luck with CTAN @xaviermawet?

xaviermawet commented 1 year ago

Hi @OJFord, I'll look into it very soon but with work and family, I haven't found the time to do it yet. I also contacted Marcel Fabian Krüger, author of the fontawesome5 package, and he told me he had no plan to create a fontawesome6 package. I keep you informed in the coming weeks

OJFord commented 1 year ago

Of course, no problem, just noticed you added some commits do wondered if you'd managed it.

Cheers

cats256 commented 1 year ago

I planned on opening a pull request for this but then I realized there's already one opened. Why not just remove (or comment on) \RequirePackage{fontawesome} in awesome-cv.cls and add a new package in resume.tex using \usepackage{fontawesome5}? |

Edit: Never mind. I just realized the font package is already Font Awesome 5

xaviermawet commented 1 year ago

I uploaded a package named fontawesome6 on CTAN. I'm waiting for validation !

OJFord commented 1 year ago

Oh great, nice one 🙂

cats256 commented 1 year ago

@xaviermawet I can't find the package on CTAN

xaviermawet commented 1 year ago

@willb256 the package hasn't been validated yet. I'm currently discussing with one CTAN's validator and the authors of others fontawesome packages to synchronize us about the package naming vs fontawesome version, the macros collision with other fontawesome packages, etc... So my package isn't available yet because it didn't pass the validation phase right now. But it should be available soon. Stay tune !

Loco169976 commented 1 year ago

🥺

github-actions[bot] commented 1 year ago

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

github-actions[bot] commented 8 months ago

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

OJFord commented 7 months ago

This bot seems a bit annoying @posquit0, I'm not sure we get enough (genuine) PRs that we can't make that judgement 'manually' - any objection to turning it off? Or at least only running on PR creation, not every update (which can get very noisy as here).

posquit0 commented 7 months ago

For now, I've excluded the binary files and the examples directory for pull-request-labler action. I don't think this will solve the problem, so I'll look into something else soon.

github-actions[bot] commented 1 month ago

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.