search

posquit0 / Awesome-CV

:page_facing_up: Awesome CV is LaTeX template for your outstanding job application
LaTeX Project Public License v1.3c
22.28k stars 4.71k forks source link

Long github names break #435

Closed khinshankhan closed 1 year ago

khinshankhan commented 2 years ago

Issue: When using my full github name (khinshankhan), I get this error: image

This doesn't seem to be an issue with the number of characters in the header (it was working if i put my github name as k, and since my linkedin is the same as github, I tried swapping them and still got the error).

Potential Fix: I'm not wholly familiar with latex, but I think this line is the culprit https://github.com/posquit0/Awesome-CV/blob/5b05d935658377c73a3456269d23a276b19804f7/awesome-cv.cls#L495

Looking at the linkedin logic, I replaced the line with

\href{https://github.com/\@github}{\faGithubSquare\acvHeaderIconSep{\expandafter\ul\expandafter{\@github}}}%

and it works like a charm. Wonder if this should be merged in if it's 'proper'.

github-actions[bot] commented 2 years ago

:wave: Welcome! Looks like this is your first issue.

Hey, thanks for your contribution! Please give us a bit of time to review it. 😄

OJFord commented 2 years ago

Thanks! Could you submit as a PR?

khinshankhan commented 1 year ago

Hello, I updated to the latest awesome cv and this fix is no longer needed. Unless someone else comes along with the same issue, I think we can safely close this. Thanks for your hard work :+1: